+1 (binding) - Checked release file name and location: *OK*
- Checked sum and signatures: *OK* - Checked DISCLAIMER file exists: *OK* - Checked LICENSE and NOTICE files: *OK* * License of 3rd-party code contained correctly mentioned in LICENSE: *OK* * Included dependencies are mentioned in LICENSE: *OK* * Un-included software dependencies are not mentioned in LICENSE or NOTICE: *OK* * Relevant part of NOTICE files of referred/contained ASF codes added into NOTICE: *OK* * NOTICE year: *OK* - Checked no binary files in source package: *OK* - Checked compile from source: *OK* (JDK 8u181) - Checked UT could pass: *OK* (JDK 8u181) Best Regards, Yu On Fri, 24 Feb 2023 at 14:06, Kent Yao <y...@apache.org> wrote: > +1 non-binding > > incubating in the name > sig and checksum are valid > DISCLAIMER/LICENSE/NOTICE are fine > no unexpected binaries in the source > ASF headers on source files are fine. > > Kent > > On 2023/02/24 04:38:23 Justin Mclean wrote: > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in the name > > - signature and hashes are fine > > - DISCLAIMER exists > > - LICENSE and NOTICE are fine > > - No unexpected binary files > > - ASF headers on source files > > - Can compile from source > > > > I dislike "Copyright 2014 and onwards", but that's Spark's issue, not > yours. I wonder if you need an ASF header on [1]. The ASF header states > "Licensed to the Apache Software Foundation (ASF) under one or more > contributor license agreements." is this true for this file? > > > > Kind Regards, > > Justin > > > > 1. > ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
