Hi Justin and Willem, Thanks for your feedback!
The file [1] is based on Spark's file[2], we had very little modification, and we leave the ASF header unmodified as it is[2]. We will remove the header in later releases. Thanks, Keyong Zhou 1. ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java 2. https://github.com/apache/spark/blob/v3.1.1/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java Justin Mclean <jus...@classsoftware.com> 于2023年2月24日周五 12:38写道： > Hi, > > +1 (binding) > > I checked: > - incubating in the name > - signature and hashes are fine > - DISCLAIMER exists > - LICENSE and NOTICE are fine > - No unexpected binary files > - ASF headers on source files > - Can compile from source > > I dislike "Copyright 2014 and onwards", but that's Spark's issue, not > yours. I wonder if you need an ASF header on [1]. The ASF header states > "Licensed to the Apache Software Foundation (ASF) under one or more > contributor license agreements." is this true for this file? > > Kind Regards, > Justin > > 1. > ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
