Hi Gang, Thanks for you feedback!
We do keep contents of the original NOTICE file of `log4j-core-2.17.2.jar` without [1], but separate [2] and [3] for alphabetical ordering. We will put [2] and [3] together in future releases. Thanks, Keyong Zhou [1] `This product includes software developed at The Apache Software Foundation (http://www.apache.org/).` [2] `Apache Log4j Core Copyright 1999-2012 Apache Software Foundation` [3] `ResolverUtil.java Copyright 2005-2006 Tim Fennell` li gang <lgcar...@apache.org> 于2023年2月28日周二 19:11写道： > Thanks for the PR link [1].It explained the content [2] is copied from the > NOTICE of `log4j-core-2.17.2.jar`,It's right to keep it in the NOTICE file. > > BTW,I suggest keep the original NOTICE file of `log4j-core-2.17.2.jar`,of > course can remove the content [3]. > It might be easier to see which dependency [2] comes from. > > 1. > > https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857 > 2.`ResolverUtil.java Copyright 2005-2006 Tim Fennell` > 3.`This product includes software developed at > The Apache Software Foundation (http://www.apache.org/).` > <http://www.apache.org/).> > > Yu Li <car...@gmail.com> 于2023年2月27日周一 18:54写道： > > > @Gang > > About the ResolverUtil.java Copyright occurring in the NOTICE file of the > > binary release, it's a transitive dependency from log4j-core. The same > > question was raised and discussed in a previous PR review [1] thus I have > > the memory, JFYI. > > > > Best Regards, > > Yu > > > > [1] > > > > > https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857 > > > > > > On Sun, 26 Feb 2023 at 12:31, li gang <lgcar...@apache.org> wrote: > > > > > +1 (binding) > > > I checked > > > - Files have the word incubating in their name. > > > - DISCLAIMER,LICENSE and NOTICE files exist.qq > > > - Checksums and signatures are valid. > > > - No unexpected binary files in the source release. > > > > > > The NOTICE file under binary release contains unexpected content > > > `ResolverUtil.java Copyright 2005-2006 Tim Fennell`,please remove it > and > > > check whether `ResolverUtil.java` is the third-pary work. > > > > > > Ethan Feng <ethanf...@apache.org> 于2023年2月24日周五 11:48写道： > > > > > > > Hello Incubator Community, > > > > > > > > This is a call for a vote to release Apache Celeborn(Incubating) > > > > version 0.2.0-incubating-rc5 > > > > > > > > The Apache Celeborn community has voted on and approved a proposal to > > > > release > > > > Apache Celeborn(Incubating) version 0.2.0-incubating-rc5 > > > > > > > > We now kindly request the Incubator PMC members review and vote on > this > > > > incubator release. > > > > > > > > Celeborn community vote thread: > > > > • https://lists.apache.org/thread/6f28tyvqsqdpjr0wpg2low4hlh39bx4j > > > > > > > > Vote result thread: > > > > • https://lists.apache.org/thread/9bhflkrwrmk81w1stbhvztzc6mb6gjco > > > > > > > > The release candidate: > > > > • > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc5 > > > > > > > > Git tag for the release: > > > > • > > > > > > > > > > https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc5 > > > > > > > > Public keys file: > > > > • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS > > > > > > > > The change log is available in: > > > > • > > > > > > > > > > https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc5 > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > number > > > > of votes are reached. > > > > > > > > Please vote accordingly: > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > More detailed checklist please refer: > > > > • > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > Steps to validate the release， Please refer to: > > > > • https://www.apache.org/info/verification.html > > > > > > > > Thanks, > > > > Ethan Feng > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > -- > > > > > > > > > ------------------------------ > > > Best Regards > > > > > > DolphinScheduler PMC > > > Gang Li 李岗 > > > > > > lgcar...@apache.org > > > > > > > > -- > > > ------------------------------ > Best Regards > > DolphinScheduler PMC > Gang Li 李岗 > > lgcar...@apache.org >
