Hi, Sorry but it's -1 (binding) from me as LICENSE and NOTICE need a little more work and quite a few sure files are missing ASF headers.
I checked: - incubating in name - signature and hash are fine (Although you might want to consider changing your apache id, it's signed with lzljs3620...@apache.org which I thought at first might not be a real email address) - LICENSE is missing license for [1] (see [2]) and other files and the mavin wrapper. It would also be good if the LICENSE included more information i.e. what products and versions the 3rd party code is from. - NOTICE is not correct. For instance, these NOTICE files [12][13] haven't been included correctly. It is unclear why Apache Flink and Apache Hadoop are mentioned; this information is missing from LICENSE. - No unexpected binary files - These files are missing ASF headers [3][4][5] and other files in that directory, and these directories [6][7][8][9][10] and other directories under [11]. Are they ASF files and how are they licensed? Kind Regards, Justin 1. ./docs/static/font-awesome/fonts/fontawesome-webfont.svg 2. https://fontawesome.com/v4/license/ 3. ./paimon-common/src/test/resources/codesplit/add-boolean/code/TestAddBooleanBeforeReturn.java 4. ./paimon-common/src/test/resources/codesplit/add-boolean/code/TestNotRewrite.java 5. ./paimon-common/src/test/resources/codesplit/add-boolean/code/TestRewriteInnerClass.java 6. ./paimon-common/src/test/resources/codesplit/add-boolean/expected/ 7. ./paimon-common/src/test/resources/codesplit/declaration/code/ 8. ./paimon-common/src/test/resources/codesplit/declaration/expected/ 9. ./paimon-common/src/test/resources/codesplit/function/code/ 10. ./paimon-common/src/test/resources/codesplit/function/expected/ 11. /paimon-common/src/test/resources/codesplit/ 12. https://github.com/aws/aws-sdk-java/blob/master/NOTICE.txt 13. https://github.com/linkedin/PalDB/blob/master/NOTICE --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
