On Sunday, January 27, 2013 03:00:21 PM Pacho Ramos wrote: > Currently, when people uses DOC_CONTENTS variable to place their desired > messages, they are automatically reformatted by "fmt" to get proper > messages (for example, splitting long lines). > > But, in some cases, may be useful to disable this behavior and respect > strictly how DOC_CONTENTS was formatted, for example in that kind of > messages telling people to run a command and, then, requiring a new line > to be used. This can also be useful to append extra information to > DOC_CONTENTS when, for example, additional info is needed when enabling > a USE flag. >
Why does this eclass even exist? Everything that it does can be done directly in an ebuild in a couple lines of code, except in a much less ugly manner. It doesn't help to generalize anything. If you want to copy a file and call dodoc then just do it, don't write a pointless wrapper that people then have to go and look up what it does in order to read your ebuilds. The only thing I see that's maybe useful is saving on the logic for checking REPLACING_VERSIONS. You can get rid of all that UUOC / UUOE. The set -f and eshopts stuff is unnecessary. You should localize the variables that can be localized like ELINE. Funnily, looking at the implementation of elog, it appears to already mangle its input by a pass of `echo -e', pointlessly reading lines and joining them back together again repeatedly. This is just horrible! I don't even... -- Dan Douglas
signature.asc
Description: This is a digitally signed message part.
