On 7 February 2015 at 23:06, hasufell <hasuf...@gentoo.org> wrote:
>>>> DEPEND=""
>>>
>>> unzip is missing from DEPEND
>>
>> I thought portage auto-depends on this. But I can add || ( unzip zip )
>> to be explicit.
>>
>
> I don't know, but it's definitely not in @system. Afair we are only
> allowed to omit deps from that set.
OK, added.
>>>> src_compile() {
>>>> local my_arch
>>>> use x86 && my_arch=x86-32-old
>>>> use cpu_flags_x86_sse && my_arch=x86-32
>>>> use amd64 && my_arch=x86-64
>>>> use cpu_flags_x86_popcnt && my_arch=x86-64-modern
>>>> use cpu_flags_x86_avx2 && my_arch=x86-64-bmi2
>>>>
>>>> emake build ARCH=${my_arch} CXX="$(tc-getCXX)" CXXFLAGS="${CXXFLAGS}"
>>>
>>> This currently breaks all cpu flags, because it overwrites anything the
>>> Makefile does to CXXFLAGS, including -msse and -DIS_64BIT and even other
>>> flags that are not CPU specific (e.g. -DNDEBUG).
>>
>> Thanks for catching this! I guess we do need to patch the Makefile
>> then, to *also* honour user-set CXXFLAGS and LDFLAGS. Or could we get
>> away with just letting the Makefile do its thing?
>>
>
> I've hit this bug myself in my overlay... I'll probably get up a pull
> request upstream today.
I think it's okay now. They do += so the user cxxflags and ldflags do
get honoured, but they end their own flags at the end of it. I've
added some more configuration options to the ebuild (optimize and
debug are important here).
--
Cheers,
Ben | yngwin
Gentoo developer
