W dniu czw, 14.12.2017 o godzinie 13∶56 +0100, użytkownik Fabian Groffen napisał: > On 14-12-2017 13:39:18 +0100, Michał Górny wrote: > > Dnia 14 grudnia 2017 13:21:47 CET, Fabian Groffen <grob...@gentoo.org> > > napisał(a): > > > Can we make it a policy to list /what/ QA issues are the justification > > > for commits like these? A description in the commit message would be > > > preferred, but a pointer to a location where said issues can be found > > > would do too. > > > > Maintainer-needed is reason enough. If somebody couldn't be bothered to > > maintain what he committed, why should we bother to list the issues? > > > > Using repoman and looking at CI mails is also a good idea. > > Obviously for me to learn something, I won't/can't use repoman here. So > a pointer to said CI mails from the message of the QA commit would be > nice.
Last I checked, I wasn't personally responsible for teaching people ebuild writing 101 while on phone. But here you go (in malformed paste of ebuild below). > diff --git a/dev-libs/libunibreak/Manifest > > > > > > b/dev-libs/libunibreak/Manifest > > > > deleted file mode 100644 > > > > index 487fd898f5d..00000000000 > > > > --- a/dev-libs/libunibreak/Manifest > > > > +++ /dev/null > > > > @@ -1 +0,0 @@ > > > > -DIST libunibreak-4.0.tar.gz 629403 SHA256 > > > > > > f7329bef1eb169d3363f040cefcc323cfd0a0bc53290a35a395e1d1adc849539 SHA512 > > > 43da73f66fabd8fdef444c5a06ad1800464a0aeab590938522d6c19973950a242f2ccc0575a93d10d87bdcf82610452117ac081ddb73f47271a8c2a65897e11c > > > WHIRLPOOL > > > ad71bc5910ca3dff994651022a5a6c6093cd4023852270fa243848f7576287b7cec4ad02a6b27686149491cb52824a93fdb6a6dac4c878d67db2f4041282d300 Those are not correct checksums for a newly added distfile. > > > > > > > > diff --git a/dev-libs/libunibreak/libunibreak-4.0.ebuild > > > > > > b/dev-libs/libunibreak/libunibreak-4.0.ebuild > > > > deleted file mode 100644 > > > > index f531bb66e38..00000000000 > > > > --- a/dev-libs/libunibreak/libunibreak-4.0.ebuild > > > > +++ /dev/null > > > > @@ -1,39 +0,0 @@ > > > > -# Copyright 1999-2017 Gentoo Foundation > > > > -# Distributed under the terms of the GNU General Public License v2 > > > > - > > > > -EAPI=6 > > > > -inherit versionator > > > > - > > > > -DESCRIPTION="Line and word breaking library" > > > > -HOMEPAGE="http://vimgadgets.sourceforge.net/libunibreak/"; > > > > > > > > > > -SRC_URI="https://github.com/adah1972/${PN}/releases/download/${PN}_$(replace_all_version_separators > > > '_')/${P}.tar.gz" > > > > - > > > > -LICENSE="ZLIB" > > > > -SLOT="0" > > > > -KEYWORDS="~amd64 ~arm ~ppc ~x86" > > > > -IUSE="doc +man static-libs" > > > > - > > > > -DEPEND="man? ( app-doc/doxygen )" > > > > -RDEPEND="!dev-libs/liblinebreak" > > > > - > > > > -src_prepare() { > > > > - use man && echo -e 'GENERATE_MAN=YES\nGENERATE_HTML=NO' >> > > > > Doxyfile Missing || die. Also don't use 'echo -e', it teaches people bad practices and it's awfully unreadable. > > > > - default > > > > -} > > > > - > > > > -src_configure() { > > > > - econf \ > > > > - $(use_enable static-libs static) > > > > - use doc && export HTML_DOCS=( doc/html/. ) Why is this exported? And what does it have to do with src_configure? > > > > -} > > > > - > > > > -src_compile() { > > > > - default > > > > - use man && doxygen || die Gratz, USE=-man dies. > > > > -} > > > > - > > > > -src_install() { > > > > - default > > > > - prune_libtool_files Deprecated. > > > > - use man && find "${D}/usr/include" -type f -execdir doman > > > "${S}/doc/man/man3/{}.3" \; > > > > -} Why this hackery? Can't you just doman doc/man/man3/*.3? > > > > > > > > diff --git a/dev-libs/libunibreak/metadata.xml > > > > > > b/dev-libs/libunibreak/metadata.xml > > > > deleted file mode 100644 > > > > index a8bbb441f29..00000000000 > > > > --- a/dev-libs/libunibreak/metadata.xml > > > > +++ /dev/null > > > > @@ -1,14 +0,0 @@ > > > > -<?xml version="1.0" encoding="UTF-8"?> > > > > -<!DOCTYPE pkgmetadata SYSTEM > > > > > > "http://www.gentoo.org/dtd/metadata.dtd";>; > > > > -<pkgmetadata> > > > > - <!-- maintainer-needed --> > > > > - <longdescription lang="en"> > > > > - Libunibreak is an implementation of the line breaking > > > > and word > > > > > > breaking algorithms > > > > - as described in Unicode Standard Annex 14 and Unicode > > > > Standard > > > > > > Annex 29. It is > > > > - designed to be used in a generic text renderer. > > > > - </longdescription> > > > > - <use> > > > > - <flag name="man">Generate man pages with doxygen.</flag> > > > > - <flag name="doc">Install html API documentation.</flag> Sort by name. > > > > - </use> > > > > -</pkgmetadata> > > > > > > > > > > > > > > -- > > Best regards, > > Michał Górny (by phone) > > > > -- Best regards, Michał Górny
