Thanks Andrea. Comments inline.
On Sun, Mar 6, 2016 at 3:00 AM Andrea Aime <andrea.a...@geo-solutions.it>
wrote:
> Hi Justin,
> had a very quick look, GeoServer wise the only thing I noticed was the
> lack of header upgrades (which
> can be done later), all the other changes look reasonable (but mind, I
> haven't used Spring 4 anywhere else).
>
>
> On Sat, Mar 5, 2016 at 6:23 PM, Justin Deoliveira <jdeol...@gmail.com>
> wrote:
>
>> Hey folks, thought I would send a quick update on progress. To recap the
>> branch currently being worked on is here:
>>
>> https://github.com/geoserver/geoserver/tree/spring4-upgrade
>>
>> The branch currently contains:
>>
>> - Core upgrades to spring 4.2.5 and spring security 4.0.4
>> - Upgrade to servlet api 3.0.1
>> - Andreas work to migrate from mockrunner to spring-test
>>
>> I also pushed a branch for geowebcache:
>>
>> https://github.com/GeoWebCache/geowebcache/tree/spring-servlet-upgrade
>>
>
> Tried to build this one, I get a failure in gwc-wmts:
>
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.632 sec
> <<< FAILURE!
> testGetTileWithStyle(org.geowebcache.service.wmts.WMTSServiceTest) Time
> elapsed: 0.416 sec <<< FAILURE!
> java.lang.AssertionError:
> Expected: map containing ["STYLES"->"Bar"]
> but: map was []
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
> at
> org.geowebcache.service.wmts.WMTSServiceTest.testGetTileWithStyle(WMTSServiceTest.java:524)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:255)
> at junit.framework.TestSuite.run(TestSuite.java:250)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> at
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> at
> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
>
> It was a simple fix for a mock expectation, so I've fixed it. One liner
> change pushed to the branch.
>
Nice, thanks!
>
>
>>
>> Although it looks like Kevin already did the work here?:
>>
>> https://github.com/GeoWebCache/geowebcache/tree/spring4-upgrade
>>
>
> Looks like this one misses the servlet api upgrade though.
>
>
>>
>>
>> At any rate, one of those branches will be required to build the
>> geoserver branch.
>>
>> At the moment all the core modules compile and pass tests. With the
>> exception of one wms test that from what I can tell was some wierd osx
>> failure. It would be nice if someone else could verify that though.
>>
>
> No failures in wms here (also made a fresh build of geotools to be on the
> safe side), do you have details?
> I've made a full build and I have failures in the following extensions:
> CAS (expected), WPS, XSLT, monitoring hibernate... not all
> that many in the end.
> Assuming you're not working on it right now, I'm going to have a quick
> look.
>
>
I’ve attached the failure trace I get
from testCoverageViewMap(org.geoserver.wms.wms_1_1_1.GetMapIntegrationTest).
I am pretty sure I have seen this failure before in my environment.
>> I’ve also run the server and everythign starts up ok, but I haven’t poked
>> it much harder than a quick smoke test.
>>
>> There is one interesting thing that I found with spring security. The
>> login and logout endpoints have changed. So “/j_spring_security_check" is
>> now “/login” and “/j_spring_security_logout” is now “/logout”. I’m still
>> unsure what the backwards compatability repercussions will be with this. It
>> looks like those paths are configurable in some places (like if using
>> annotation based config) but the way we are using some of the filters it
>> didn’t look like they were. I was going to circle back to this.
>>
>
> Hum... thinking, don't we have some javascript apps around using these
> endpoints to test authentication
> when using a custom login form?
>
Yeah, I know of one app (geoexplorer) that uses one of the endpoints to
create a session. One thought I had (if we can’t configure the endpoint
paths) was to create a redirect from old to the new.
>
> Cheers
> Andrea
>
> --
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
>
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
> -------------------------------------------------------
>
org.geoserver.platform.ServiceException: Error rendering coverage on the fast
path
at
org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:346)
at
org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:261)
at
org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:131)
at org.geoserver.wms.GetMap.executeInternal(GetMap.java:505)
at org.geoserver.wms.GetMap.run(GetMap.java:249)
at org.geoserver.wms.GetMap.run(GetMap.java:119)
at
org.geoserver.wms.DefaultWebMapService.getMap(DefaultWebMapService.java:320)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:302)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at
org.geoserver.ows.util.RequestObjectLogger.invoke(RequestObjectLogger.java:33)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
at com.sun.proxy.$Proxy42.getMap(Unknown Source)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.geoserver.ows.Dispatcher.execute(Dispatcher.java:840)
at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:268)
at
org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:147)
at
org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:50)
at
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:959)
at
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:893)
at
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:968)
at
org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:859)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)
at
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:844)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:770)
at
org.geoserver.test.GeoServerSystemTestSupport$1.service(GeoServerSystemTestSupport.java:1452)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:770)
at
org.springframework.mock.web.MockFilterChain$ServletFilterProxy.doFilter(MockFilterChain.java:167)
at
org.springframework.mock.web.MockFilterChain.doFilter(MockFilterChain.java:134)
at
org.geoserver.test.GeoServerSystemTestSupport.dispatch(GeoServerSystemTestSupport.java:1479)
at
org.geoserver.test.GeoServerSystemTestSupport.dispatch(GeoServerSystemTestSupport.java:1410)
at
org.geoserver.test.GeoServerSystemTestSupport.getAsServletResponse(GeoServerSystemTestSupport.java:972)
at
org.geoserver.test.GeoServerSystemTestSupport.getAsServletResponse(GeoServerSystemTestSupport.java:955)
at
org.geoserver.test.GeoServerSystemTestSupport.getAsImage(GeoServerSystemTestSupport.java:1243)
at
org.geoserver.wms.wms_1_1_1.GetMapIntegrationTest.testCoverageViewMap(GetMapIntegrationTest.java:760)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
Caused by: org.geoserver.platform.ServiceException:
org.geotools.coverage.processing.CoverageProcessingException:
java.lang.UnsupportedOperationException: Not implemented
at
org.geoserver.wms.map.RenderedImageMapOutputFormat.directRasterRender(RenderedImageMapOutputFormat.java:1083)
at
org.geoserver.wms.map.RenderedImageMapOutputFormat.produceMap(RenderedImageMapOutputFormat.java:344)
... 73 more
Caused by: org.geotools.coverage.processing.CoverageProcessingException:
java.lang.UnsupportedOperationException: Not implemented
at
org.geotools.renderer.lite.gridcoverage2d.BaseCoverageProcessingNode.getOutput(BaseCoverageProcessingNode.java:343)
at
org.geotools.renderer.lite.gridcoverage2d.BaseCoverageProcessingNode.getOutput(BaseCoverageProcessingNode.java:46)
at
org.geotools.renderer.lite.gridcoverage2d.StyleVisitorCoverageProcessingNodeAdapter.getOutput(StyleVisitorCoverageProcessingNodeAdapter.java:141)
at
org.geotools.renderer.lite.gridcoverage2d.GridCoverageRenderer.symbolize(GridCoverageRenderer.java:472)
at
org.geotools.renderer.lite.gridcoverage2d.GridCoverageRenderer.renderImage(GridCoverageRenderer.java:974)
at
org.geotools.renderer.lite.gridcoverage2d.GridCoverageRenderer.renderImage(GridCoverageRenderer.java:768)
at
org.geoserver.wms.map.RenderedImageMapOutputFormat.directRasterRender(RenderedImageMapOutputFormat.java:975)
... 74 more
Caused by: java.lang.UnsupportedOperationException: Not implemented
at
org.jaitools.imageutils.ROIGeometry.getAsRectangleList(ROIGeometry.java:488)
at
com.sun.media.jai.opimage.ExtremaOpImage.accumulateStatistics(ExtremaOpImage.java:184)
at javax.media.jai.StatisticsOpImage.getProperty(StatisticsOpImage.java:300)
at
com.sun.media.jai.opimage.ExtremaOpImage.getProperty(ExtremaOpImage.java:108)
at javax.media.jai.RenderedOp$1.getProperty(RenderedOp.java:1819)
at
javax.media.jai.PropertyEnvironment.getProperty(PropertyEnvironment.java:207)
at javax.media.jai.PropertySourceImpl.getProperty(PropertySourceImpl.java:285)
at
javax.media.jai.WritablePropertySourceImpl.getProperty(WritablePropertySourceImpl.java:138)
at javax.media.jai.RenderedOp.getProperty(RenderedOp.java:1993)
at org.geotools.image.ImageWorker.getComputedProperty(ImageWorker.java:961)
at org.geotools.image.ImageWorker.getExtremas(ImageWorker.java:1015)
at org.geotools.image.ImageWorker.rescaleToBytes(ImageWorker.java:1319)
at
org.geotools.renderer.lite.gridcoverage2d.RasterSymbolizerHelper.execute(RasterSymbolizerHelper.java:131)
at
org.geotools.renderer.lite.gridcoverage2d.RasterSymbolizerHelper.execute(RasterSymbolizerHelper.java:58)
at
org.geotools.renderer.lite.gridcoverage2d.StyleVisitorCoverageProcessingNodeAdapter$1.execute(StyleVisitorCoverageProcessingNodeAdapter.java:102)
at
org.geotools.renderer.lite.gridcoverage2d.BaseCoverageProcessingNode.checkExecuted(BaseCoverageProcessingNode.java:238)
at
org.geotools.renderer.lite.gridcoverage2d.BaseCoverageProcessingNode.getOutput(BaseCoverageProcessingNode.java:341)
... 80 more
------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
