On Thu, Aug 7, 2014 at 1:30 AM, jerickson <jared.erick...@gmail.com> wrote:

> Hi Andrea!
>
> I think there are two things going on.  First, the Copy link assumes that
> code mirror has been applied.  I think this will be a quick fix. If the
> browser doesn't support code mirror we can just find the textarea.


Right.


> Second,
> it appears that Wicket 1.3.2 does not really do a good job at browser
> detection.  Check out the WebClientInfo class:
>
>
> https://github.com/apache/wicket/blob/wicket-1.3.2/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java


We are actually using 1.4.12:
https://github.com/apache/wicket/blob/wicket-1.4.12/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java

Wondering if we really care about versions other than IE ones... I mean,
Chrome and Firefox do auto-update,
what's the likeliness of stumbling into a old version of them? Sites that
are forcing a fixed and old
version of those should be pretty rare.


>
> It doesn't actually parse versions for any browser but IE.  Wicket's
> WebClientInfo on master branch does a much better job:
>
>
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
>
> Do you think we could borrow from that class to better support browser
> detection?
>

Hum... not sure, we should ask Jody, he's our resident licence expert

Cheers
Andrea

-- 
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-users mailing list
Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Reply via email to