Hey all, I've already lost time on this, on top of a bunch of other things so I don't have time to chase down the problems and fix them.
On Thu, 2008-08-07 at 08:31 -0700, Jody Garnett wrote: > I was under the impression that we were getting formal when code moved > to a supported module; and we were going to try and not make > the unsupported modules available for download (or at least in a > separate jar). yes, that seems reasonable and was my understanding as well. > Do we have Jira issues to track the problems you refer to > Adrian; I have not been paying attention to this module very closely (I > try to focus on library/* if I can). > > Jody I haven't looked at the code of the Geotools module itself; I'm assuming that's clean since our review for graduation was exhaustive. That's not the code that's at issue. The code that's at issue is the external stuff pulled in by this module when it builds. Building the module pulls in the code from the imageio-ext project off in sun's sourceforge equivalent whatever it's called. A quick look at that code raised a bunch of issues which is both good and bad: good that that is documented bad that we can't distribute the code. My review was trivial. I opened all the license.txt files then opened all the java files. Just reading the documented stuff showed me that the code needs work, thinking, fixing, before it can even be read. Distribution places additional restrictions which Geotools cannot meet today. So there's work there but the project is being worked on so it should get to the point where it can work. ************************************************************* On Thu, 2008-08-07 at 17:35 +0200, Andrea Aime wrote: > > Looked into it, the file in question has been removed from > their svn. Thanks for noticing it, it was indeed problematic license > wise. There were three or four taken from SUN internal code, if I remember right. > > > Hopefully, imageio-ext will undergo a formal review of its own, clean up > > what needs cleaning, and make an initial release when it's ready. After > > that, Geotools will be able to consider the formal dependency. > > What would the review consist of? Make it up. How did Geotools try to guarantee that the code it distributes is above board? How does Geoserver do that? 1) code legality (origin, license compatiblity...) 2) code quality 3) number of external dependencies 4) maturity/stability of the project ... > > Second observation, sorry if a bit sarcastic, but to be fair, > shouldn't we check that every library we're using goes thought > a formal review process? Right, that's why we trust foundations (Apache), big well known companies (IBM, SUN), libraries by people we know and respect, libraries with track records. It's also why dependencies are problematic. > Did anybody formally check that all the libraries we depend onto > are clean license wise? > Cheers > Andrea **************************************************************** On Thu, 2008-08-07 at 17:40 +0200, Simone Giannecchini wrote: On Thu, Aug 7, 2008 at 5:19 PM, Adrian Custer <[EMAIL PROTECTED]> wrote: > Could you please share with the enthusiastic imageio-ext developers > what do you mean by "there's at least one other issue I saw that makes > it impossible for us to simply include in our build"? A restriction on distribution: if you distribute you must...which is incompatible with the LGPL if memory serves. But really, that's the job of imageio-ext. We get to play Cameron's role and merely to run quick spot checks to verify that things look good. --adrian ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
