I have fixed a bunch of resource leaks (see GEOT-3273, not committed but in progress); I think the underlying problem was an unclosed FeatureIterator in MappingFeatureIterator.getCount ... a workaround used *only* for property files.
On 12/10/10 09:56, Ben Caradoc-Davies wrote: > Florence is also reporting this failure. Is anyone else seeing it on > Windows? Is it repeatable? > > Maybe this is caused by the datastore resource leak: > http://jira.codehaus.org/browse/GEOT-3273 > > Even though the app-schema DataAccess is properly disposed, it does not > dispose the underlying simple feature data store, which then keeps the > property file open until it is garbage-collected. > > Windows differs from other platforms that it does not let an application > delete an open file. This causes the tearDown in the test to fail. On > Unix platforms, file deletion is just unlinking, so this problem is not > evident (the file is only removed when it has no links and nothing has > it open). > > On 04/10/10 13:30, Ben Caradoc-Davies wrote: >> That is really weird. It looks like the sort of failures you get on >> Windows when something else has the file open. Can you please manually >> delete the file (mvnn clean would be good) and make sure nothing else >> has it open? Might be TortoiseSVN or even a virus scanner. Because this >> is a temporary directory, I would not expect you to have it open in Eclipse. >> >> Regards, >> Ben. >> >> >> On 04/10/10 12:49, Tara Athan wrote: >>> Ben- regarding your question as to test failures: I'll reply separately >>> for the geotools and geoserver failures on the appropriate lists. >>> Ironically, it is my AppSchemaFileDataTest that is giving errors. Here >>> is the sure-fire report >>> >>> ------------------------------------------------------------------------------- >>> Test set: org.geotools.data.complex.config.AppSchemaFileDataTest >>> ------------------------------------------------------------------------------- >>> Tests run: 4, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.406 >>> sec<<< FAILURE! >>> testPropertiesMappings(org.geotools.data.complex.config.AppSchemaFileDataTest) >>> Time elapsed: 1 sec<<< ERROR! >>> java.io.IOException: Unable to delete file: >>> target\test\AppSchemaFileDataTest\directory\PointFeatureGeomPropertyfile.properties >>> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1087) >>> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:811) >>> at >>> org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:777) >>> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1079) >>> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:811) >>> at >>> org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:777) >>> at >>> org.geotools.data.complex.config.AppSchemaFileDataTest.tearDown(AppSchemaFileDataTest.java:85) >>> at junit.framework.TestCase.runBare(TestCase.java:140) >>> at junit.framework.TestResult$1.protect(TestResult.java:110) >>> at junit.framework.TestResult.runProtected(TestResult.java:128) >>> at junit.framework.TestResult.run(TestResult.java:113) >>> at junit.framework.TestCase.run(TestCase.java:124) >>> at junit.framework.TestSuite.runTest(TestSuite.java:232) >>> at junit.framework.TestSuite.run(TestSuite.java:227) >>> at >>> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:81) >>> at >>> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) >>> at >>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) >>> at >>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) >>> at org.apache.maven.surefire.Surefire.run(Surefire.java:177) >>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>> at >>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) >>> at >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >>> at java.lang.reflect.Method.invoke(Method.java:592) >>> at >>> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) >>> at >>> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) >>> >>> testPropertiesMappingsAbsolute(org.geotools.data.complex.config.AppSchemaFileDataTest) >>> Time elapsed: 0 sec<<< ERROR! >>> java.io.IOException: Unable to delete file: >>> target\test\AppSchemaFileDataTest\directory\PointFeatureGeomPropertyfile.properties >>> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1087) >>> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:811) >>> at >>> org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:777) >>> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1079) >>> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:811) >>> at >>> org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:777) >>> at >>> org.geotools.data.complex.config.AppSchemaFileDataTest.setUp(AppSchemaFileDataTest.java:69) >>> at junit.framework.TestCase.runBare(TestCase.java:132) >>> at junit.framework.TestResult$1.protect(TestResult.java:110) >>> at junit.framework.TestResult.runProtected(TestResult.java:128) >>> at junit.framework.TestResult.run(TestResult.java:113) >>> at junit.framework.TestCase.run(TestCase.java:124) >>> at junit.framework.TestSuite.runTest(TestSuite.java:232) >>> at junit.framework.TestSuite.run(TestSuite.java:227) >>> at >>> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:81) >>> at >>> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) >>> at >>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) >>> at >>> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) >>> at org.apache.maven.surefire.Surefire.run(Surefire.java:177) >>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>> at >>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) >>> at >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >>> at java.lang.reflect.Method.invoke(Method.java:592) >>> at >>> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345) >>> at >>> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009) >> >> >> > > > -- > Ben Caradoc-Davies<ben.caradoc-dav...@csiro.au> > Software Engineering Team Leader > CSIRO Earth Science and Resource Engineering > Australian Resources Research Centre > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2& L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Ben Caradoc-Davies <ben.caradoc-dav...@csiro.au> Software Engineering Team Leader CSIRO Earth Science and Resource Engineering Australian Resources Research Centre ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
