On Sat, May 7, 2011 at 3:22 AM, Jody Garnett <jody.garn...@gmail.com> wrote:
> Hi Andrea:
> I have another idea that came up when looking at the patch (sorry for
> picking on your patch Michael,  I feel bad as this work is 1/2 done, and my
> fault in that respect).
> You have hit on one of two remaining tasks:
> 1) update StreamingRenderer to use MapContent
> 2) update StreamingRenderer to support DirectLayer
> With respect to (1) ....
> Andrea how do you feel about making MapContent, MapViewport and Layer part
> of gt-api? We could not have the explicit subclasses like FeatureLayer
> defined in gt-api (as for example FeatureLayer would be defined by gt-main
> in order to make use of DataUtilities).
> To make that approach "smooth" I would also define a Render interface (to
> hold setMapContent / getMapContent) and have GTRender extend that:
> The GTRender / MapContext / MapLayer classes would remain in gt-render,
> existing client code can continue to use it as a "nice" way of setting up a
> MapContent.

Maybe? The thing is, I never used any of these classes, don't know what they
are up to. I recall it as an experiment of some time ago, but it's
actually something
that I don't know anything about, so it's difficult for me to comment on it.
What makes the new classes better? Are we going to replace the old ones,
deprecated them?
So far I took a "damage control" perspective on this work, just making sure
it would not break the existing functionality, if you are serious about it
I guess I'll have to look deeper into it but having some reference would
sure help fit this into the time I can dedicate to unfunded work, which is,
bits and pieces of the weekend.

Breaking new core API (and deprecating old one) is proposal material too,
it also requires a description of how to go from the former to the latter.

Long story short, I have no preconception against the new classes,
but would like more time to look into it (whether you want to start with
a proposal right now or wait for a more informed opinion from my part,
that is up to you)

Cheers
Andrea

-- 
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy

phone: +39 0584 962313
fax:      +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to