On Sun, May 8, 2011 at 1:52 AM, Jody Garnett <jody.garn...@gmail.com> wrote: > Another angle to look at this is how deep the MapContext hierarchy really > is. > GeoServer uses a WMSMapContext which is a sub-sub-subclass of MapContext. > What is going to happen to the other two subclasses of MapContext? > (see attached picture, showing the inheritance hiearchy). > > Thanks for the picture; my understanding is some of those subclasses allow > for things like watermarking;
Nope, watermarking is handled as post processing after the rendering process happened. Watermarking, and map decoration handling in general, is indeed the only cleanup we'd get in GeoServer land, updating the rest of the code to use MapContent/Layer looks like a mere refactoring otherwise (e.g., no other improvement I can see). > it is my hope that by taking these facilities into MapContent that GeoServer > can accomplish the same goal without deep subclassing. Most of the classes in that picture are actually in GeoTools so you can see them already, but anyways, here is a list of pointers to the code: http://svn.osgeo.org/geotools/trunk/modules/library/render/src/main/java/org/geotools/map/DefaultMapContext.java http://svn.osgeo.org/geotools/trunk/modules/library/render/src/main/java/org/geotools/map/GraphicEnhancedMapContext.java http://svn.codehaus.org/geoserver/trunk/src/wms/src/main/java/org/geoserver/wms/WMSMapContext.java You should see that all of them are actually just making computing some defaults easier (but stuff we don't actually need in GeoServer) or add fields that we derive from the WMS request. None of them is "active" in the sense of drawing. > I should point out that the change to MapContent has been done; and the > above code is still working correctly. Is renderer subclassed as well? The renderer is not, but I asked if you would deprecate the old classes and you confirmed. Don't want to increase deprecated code usage in GeoServer, thus I'm forced to refactor it to use the new classes. Cheers Andrea -- ------------------------------------------------------- Ing. Andrea Aime GeoSolutions S.A.S. Tech lead Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 962313 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.youtube.com/user/GeoSolutionsIT http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ------------------------------------------------------- ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
