Okay, but this is impossible because ReferencedEvelope3D cannot be derived from both Envelope3D and ReferencedEnvelope at the same time.

Unless what you mean is that I drop Envelope3D all together and merge the two classes? I can look in to that option.

Kind Regards
Niels Charlier

On 17/07/12 16:27, Justin Deoliveira wrote:
When I first read over the proposal this was my thought as well.

On Tue, Jul 17, 2012 at 5:47 AM, Jody Garnett <jody.garn...@gmail.com <mailto:jody.garn...@gmail.com>> wrote:

    That would work for me.

-- Jody Garnett

    On 17/07/2012, at 7:38 PM, Andrea Aime
    <andrea.a...@geo-solutions.it
    <mailto:andrea.a...@geo-solutions.it>> wrote:

    On Tue, Jul 17, 2012 at 10:15 AM, Jody Garnett
    <jody.garn...@gmail.com <mailto:jody.garn...@gmail.com>> wrote:

        The interface was just an idea I threw in there, because
        there were concerns about ReferencedEnvelope3D not being a
        ReferencedEnvelope.

        But the idea of not making separate classes and make the
        current ones support 3D, I think is quite tricky too.
        The algorithms aren't necessarily the same with 2d and 3d.
        Basically, every method would need to have a check whether
        there is a 3rd dimension or not.
        Agreed; it would not be fun. We do have a couple
        implementations of the opengis Envelope interface to show us
        the way however.
        Still I would rather have one class that is tricky for us to
        write; then make something that is difficult for everyone
        else to use.

        Notes:
        - this single class solution prevents you from performing an
        instance of check to determine if 2D or 3D is supported -
        will that be a problem for your code?
        - A clean way to implement would be to have an optional
        internal "delegate" opengis Envelope, if it is non null we
        can delegate to that implementation. If it is null we can
        delegate to the JTSEnvelope superclass.


    Why can't we have a ReferencedEnvelope3D extends ReferencedEnvelope?
    It would allow the writing of the custom 3d logic without
    riddling the code with if statements,
    and would allow for an instanceof check.

    Cheers
    Andrea

-- ==
    Our support, Your Success! Visit http://opensdi.geo-solutions.it
    for more information.
    ==

    Ing. Andrea Aime
    @geowolf
    Technical Lead

    GeoSolutions S.A.S.
    Via Poggio alle Viti 1187
    55054  Massarosa (LU)
    Italy
    phone: +39 0584 962313 <tel:%2B39%200584%20962313>
    fax: +39 0584 962313 <tel:%2B39%200584%20962313>
    mob: +39  339 8844549 <tel:%2B39%20%C2%A0339%208844549>

    http://www.geo-solutions.it
    http://twitter.com/geosolutions_it

    -------------------------------------------------------


    
------------------------------------------------------------------------------
    Live Security Virtual Conference
    Exclusive live event will cover all the ways today's security and
    threat landscape has changed and how IT managers can respond.
    Discussions
    will include endpoint security, mobile security and the latest in
    malware
    threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
    _______________________________________________
    GeoTools-Devel mailing list
    GeoTools-Devel@lists.sourceforge.net
    <mailto:GeoTools-Devel@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/geotools-devel




--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to