I personally get in trouble with code formats all the time. I have this habit 
of hitting "Alt-Shift-F" before committing (taken from the uDig project).
Justin has asked me to commit code formatting changes as a separate commit; but 
I have not been quite sure how this helps.
-- 
Jody Garnett


On Friday, 31 August 2012 at 6:40 PM, Andrea Aime wrote:

> On Fri, Aug 31, 2012 at 10:31 AM, Andrea Aime <andrea.a...@geo-solutions.it 
> (mailto:andrea.a...@geo-solutions.it)> wrote:
> > Hi,
> > I'm wondering if we have, anywhere in the dev guide, a tutorial on how to 
> > contribute a patch.
> > 
> 
> 
> Jody on IRC pointed me at these:
> 
> (10:34:14) jgarnett: 
> http://docs.geotools.org/latest/developer/procedures/hack.html
> (10:35:05) jgarnett: heck that page still has svn
> (10:35:13) aaime: heh
> (10:35:23) jgarnett: so total dup of
> (10:35:28) jgarnett: 
> http://docs.geotools.org/latest/developer/procedures/stable.html
> (10:35:42) jgarnett: 
> http://docs.geotools.org/latest/developer/procedures/git.html
> (10:37:27) jgarnett: (so you have several pages; and can reply to your own 
> email)
> 
> Those are a starting point, but I believe it would be good to have a page 
> explaining 
> what people will look at when doing a review, so that obvious issues like code
> reformats are avoided right from the start. 
> This one could point to the two above pages for details outside of the code 
> review
> 
> Cheers
> Andrea
> 
> -- 
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more 
> information.
> ==
> 
> Ing. Andrea Aime 
> @geowolf
> Technical Lead
> 
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054  Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax:   +39 0584 962313
> mob:   +39  339 8844549
> 
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
> 
> -------------------------------------------------------
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> 
> _______________________________________________
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net 
> (mailto:GeoTools-Devel@lists.sourceforge.net)
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
> 
> 


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to