On Wed, Dec 19, 2012 at 1:30 AM, Niels Charlier <[email protected]> wrote:
> A pull request has been sent:
>
> https://github.com/geotools/geotools/pull/88
>
> I assigned Rini, I guess she will be reviewing it? I also need a review
> for the changes in gt-main, I suppose Jody?
>
Hi,
I did not see a review from Jody so far, so I've tried to make one myself
instead (and seen that Rini made a review for the app-schema part last
week).
I did not do a line by line review, but from what I see things are looking
good.
I do have a couple of concerns though, but I don't see them as blocking the
merge of the patch.
The first one is testing related: the module complex module has a low-ish
test
coverage (29%), and all the classes contributed to "main" are without any
kind of test.
Now, from what I understand your work has been mostly refactoring of
existing code, so I certainly cannot blame you for code coverage that was
not there to begin with, or for coverage that was there when things were
all togheter in a single module, and that is no more visible due to the
split,
yet the classes I see there seem testable in isolation...
Complex feature people, any comment?
The other thing I'm working about is the xpath property accessor, I see
there is another one in xsd-core, which is something that gt-complex depends
onto.
What is the relationship between the two? Is the duplication necessary?
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
much more. Get web development skills now with LearnDevNow -
350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122812
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
