The reason of the problem is some previously forgotten code - a simple
.append(" ")
So I think we don't need a JIRA ticket for this. Would a simple pull
request be ok?
On the other side the JDBCDataStore has a lot of protected methods for
sql generation which cannot be tested easily - like the one with the
bug. I think these methods should be in some kind of utility class -
JDBCUtils and SqlUtil classes are already in the gt-jdbc module. What do
you think?
Martin
On 31.10.2018 08:36, Martin Zeller wrote:
I found a small but important problem with a commit for GEOT-6034:
https://github.com/geotools/geotools/commit/b11d0e97ef56f3afe1759a6099
628851db3db5f7
with this diff:
https://github.com/geotools/geotools/commit/b11d0e97ef56f3afe1759a6099
628851db3db5f7#diff-3f08f2af86593cd27baeb630bf1b1869L3786
"sql.append(" ").append(toSQL.encodeToString(filter));" was replaced
by "sql.append(toSQL.encodeToString(filter));" (and some more code)
which leads to an ORA-00907 with our setting.
More information (logs) please see in the geoserver-user mailing list:
http://osgeo-org.1560.x6.nabble.com/ORA-00907-with-filter-in-getfeatur
e-request-geoserver-2-14-0-td5383052.html
Kind regards
Martin Zeller
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
