On Tue, Nov 6, 2018 at 11:23 AM Martin Zeller <[email protected]> wrote:
> The reason of the problem is some previously forgotten code - a simple
> .append(" ")
> So I think we don't need a JIRA ticket for this. Would a simple pull
> request be ok?
>
> On the other side the JDBCDataStore has a lot of protected methods for
> sql generation which cannot be tested easily - like the one with the
> bug. I think these methods should be in some kind of utility class -
> JDBCUtils and SqlUtil classes are already in the gt-jdbc module. What do
> you think?
>
No need to add new tests, I believe the are some in the existing test suite
that are failing,
but they are not run, because they need a Oracle database handy and some
profiles
to activate them (basically, tell maven that you want to run them and that
you have
installed the JDBC driver, which is not redistributable).
For the driver see here:
https://github.com/geotools/geotools/blob/master/modules/plugin/jdbc/jdbc-oracle/pom.xml#L62
Then you can run the build in the module with -Ponline, it will create a
sample config file $home/.geotools/,
rename it to oracle.properties, fill in the right connection params, and
then run the build again,
this time it should actually run the tests (you can tell because it takes
like 5 minutes to do so).
We had a build on the build box, but it never passed, and eventually I
guess it was disabled.
No idea if we still have a Oracle server there to run the test suite,
anyone knows?
https://build.geoserver.org/view/geotools/job/geotools-master-online-oracle/
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Lead
GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39
0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
------------------------------------------------------- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
