Patch Set 11: (2 comments)
Thanks for your review! I actually expected more comments as you stated "some comments" in an earlier PS. :) I will apply all comments, but for two of them I need further information/clarification. Please see my comments, just want to be sure to get your points right before pushing next PS. https://gerrit.osmocom.org/#/c/2465/10/scripts/osmo-build.sh File scripts/osmo-build.sh: Line 61: # "$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]") > how is this verification step part of 'generic_deps'? It should be part of I agree. Then it's probably best to use generic_deps() only to determine artifact name. And let the build script, which sources osmo-build.sh declare build_deps() additionally to generic_deps() and build_project(). That's probably more comprehensive too? Line 170: > would be nicer to need only one way to get branch and rev ...or to be given Do you mean branch_and_rev_of{remote,local}_repo when speaking about "... needed only one way"? branch_and_rev_of_remote_repo gets branch already by caller. branch_and_rev_of_remote_repo can actually do the same. -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484 Gerrit-PatchSet: 11 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: blobb <dr.bl...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: blobb <dr.bl...@gmail.com> Gerrit-HasComments: Yes
