Patch Set 1: (1 comment)
> (4 comments) > > Thnaks a lot for your contribution! It is very much appreciated, > please forgitve me missing it in the patch review so far. It's > not usual that it waits for three weeks. If you hsould see that > again, feel free to send a "ping" either by private mail or here as > a "reply" on the patch. Thanks for your comments. I revised my patch and fixed the most things. https://gerrit.osmocom.org/#/c/2817/1/src/phy/tetra_burst.c File src/phy/tetra_burst.c: Line 305: #if 0 /* not used */ > not used by whom? why? I think more context is needed here. also, it seems You are right, it is not necessary for DMO. I comment it out because the code runs faster and it is not used in "tetra_burst_sync.c". -- To view, visit https://gerrit.osmocom.org/2817 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa5521d7313595384e74dd790a56550755b93fe9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-tetra Gerrit-Branch: laforge/sq5bpf-rebase-20161218 Gerrit-Owner: allesklar2 <jjuerg...@seemoo.tu-darmstadt.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: allesklar2 <jjuerg...@seemoo.tu-darmstadt.de> Gerrit-HasComments: Yes
