Patch Set 1: (1 comment)
Ok, I'll modify the patch to have "early-classmark-sending (2g|2g3g|forbidden)" and still accept "allowed" to be "2g3g". I'll create a previous patch changing early_cm_ctrl (and later early_cm_ctrl_3g) to be a bool. https://gerrit.osmocom.org/#/c/5021/1/src/libbsc/system_information.c File src/libbsc/system_information.c: PS1, Line 875: s > are you sure about the logic? "restrict 3G" sounds like "restrict the use o According to specs in 44.018: > Early Classmark Sending Control (1 bit field) > L Early Classmark Sending is forbidden > H Early Classmark Sending is allowed And: > 3G Early Classmark Sending Restriction (1 bit field) > L Neither UTRAN, CDMA2000 nor GERAN IU MODE CLASSMARK CHANGE message shall be > sent with the Early classmark sending > H The sending of UTRAN,CDMA2000 and GERAN IU MODE CLASSMARK CHANGE messages > are controlled by the Early Classmark Sending Control parameter So for me at least the name "Restriction" is really misleading here. 0->forbidden, 1->allowed iif "Early classmark" is also allowed, forbidden otherwise. About the uint8_t vs boolean, I stuck to the types already being used for early_cm_ctrl. I can send a new patch changing early_cm_ctrl to be a boolean though. -- To view, visit https://gerrit.osmocom.org/5021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1afe071038a3bb5871d7ff40f665c8644f801ec Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
