Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/5021/1/src/libbsc/system_information.c File src/libbsc/system_information.c: PS1, Line 875: s > According to specs in 44.018: Don't ever treat L as 0 and H as 1. 0/1/L/H are completely different symbols next to each other! In your code, the "si_info.early_cm_restrict_3g" variable means "restrict the phone from ever sending a 3G classmark in early classmark sending" And if that variable is true, then you shall encode that as "L" symbol. If the variable is false, you encode that as "H", meaning "don't restrict 3G early classmark sending when early_classmark is enabled". -- To view, visit https://gerrit.osmocom.org/5021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1afe071038a3bb5871d7ff40f665c8644f801ec Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
