Patch Set 2: I leave here for the record the rationale for implementing 2 cmds instead of 1:
"Regarding the early-classmark-3g option, I'm not entirely sure I like the idea of using only 1 cmd line, because then we have different behaviour depending on whether the cmd is set or not, and otherwise we break old behaviour. I explain: currently default behaviour is early_cm=0 and early_cm_3g=1 (hardcoded, ie. control depends on early_cm). If we use (allowed|2g-only|forbidden), then we get combinations: (1,1)|(1,0)|(0,0), but we get combination (0,1) (the current old behavior) if no option is set. And then in that case if running-config is saved, it would be saved as "forbidden", which next time the bsc is started it would be handled as (0,0), which would change the behaviour on the bits sent to the MS. Unless I use "forbidden" always as "(0,1)", which would always work, but still we miss the case to specifically send through te wire the (0,0) scenario." -- To view, visit https://gerrit.osmocom.org/5021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1afe071038a3bb5871d7ff40f665c8644f801ec Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: No
