Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 )
Change subject: libosmonetify SMPP ...................................................................... Patch Set 49: (3 comments) File src/libsmpputil/smpp_msc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/3fa9e4c2_f44d41de PS49, Line 847: if (!g_smsc->link) { > why is this check added now? Hmm.. yepp, it can be dropped. File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/6b0e2d42_9448e55f PS49, Line 166: acl->esme = NULL; > Nice bug here setting to null before calling put on it. […] Ack https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/bd987a53_ba352839 PS49, Line 760: uint32_t smpp_size = esme->read_msg ? esme->read_msg->cb[0] : 0; > you are casting unsigned long to "uint32_t". […] I think it's better to use the type which matches exactly the size from SMPP spec - 4 bytes. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 49 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 27 Oct 2022 14:36:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
