Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30345 )

Change subject: paging: Introduce VTY configurable X3113 (Maximum Paging 
Request Transmit Delay Threshold)
......................................................................


Patch Set 1:

(1 comment)

File src/osmo-bsc/paging.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/b65c2faa_b541bd35
PS1, Line 415:  struct osmo_tdef *td_x3113 = 
osmo_tdef_get_entry(bts->network->T_defs, -3113);
> the API intended way to do  […]
actually it is documented

 abort the program if default < 0

but could be more prominent



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30345
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia556ef4e474e6a2d0d1618bab680a3330a3c062b
Gerrit-Change-Number: 30345
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: neels <nhofm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Nov 2022 14:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to