Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30345 )

Change subject: paging: Introduce VTY configurable X3113 (Maximum Paging 
Request Transmit Delay Threshold)
......................................................................


Patch Set 1:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/63285b51_2b45bfb6
PS1, Line 11: timeouts, etc.
> i'm having a hard time understanding this, clarify a bit? […]
T3113 defines the amount of time that a response for a paging request is 
expected to take at maximum. Hence after T3113 timeouts the request can be 
freed/retransmitted because we now for sure that there's no answer for it.


File src/osmo-bsc/net_init.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/de69a62b_678d0cc7
PS1, Line 78: PAGING_THRESHOLD_X3113_DEFAULT_SEC
> AFAICT this is the only place where this #define is used. […]
I prefer keeping it in a define in paging.h, where I can describe better the 
meaning of it, where all related paging information is located.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30345
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia556ef4e474e6a2d0d1618bab680a3330a3c062b
Gerrit-Change-Number: 30345
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: neels <nhofm...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Nov 2022 15:17:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to