Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30345 )
Change subject: paging: Introduce VTY configurable X3113 (Maximum Paging Request Transmit Delay Threshold) ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File src/osmo-bsc/net_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/92d8f4c9_0fe37eb5 PS1, Line 78: PAGING_THRESHOLD_X3113_DEFAULT_SEC > I prefer keeping it in a define in paging. […] IMHO write "see X3113"; we can agree to disagree File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/406131fc_24ad99c8 PS1, Line 415: struct osmo_tdef *td_x3113 > const Done https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/fa41ef74_71b8f3e9 PS1, Line 415: struct osmo_tdef *td_x3113 = osmo_tdef_get_entry(bts->network->T_defs, -3113); > actually it is documented […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia556ef4e474e6a2d0d1618bab680a3330a3c062b Gerrit-Change-Number: 30345 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 15:58:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
