Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40095?usp=email )
Change subject: personalization: discover all useful ConfigurableParameter subclasses ...................................................................... Patch Set 6: -Code-Review (1 comment) Patchset: PS6: I think this must be possible to solve more elegantly or at least in my mind more pythonic. For example, by inheriting from an additional parent class in case the parameter is non-abstract (shall we call it concrete?). At that point you could then use @isinstance(foo, ConcreteParameter) in your @get_all_implementations()@ method. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4970657294130b6b65d50ff19ffbb9ebab3be609 Gerrit-Change-Number: 40095 Gerrit-PatchSet: 6 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Wed, 07 Jan 2026 12:44:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
