Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40095?usp=email )
Change subject: personalization: discover all useful ConfigurableParameter subclasses ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > I think this must be possible to solve more elegantly or at least in my mind > more pythonic. […] I agree that this is not elegant, and in the other comment i argue more towards dropping this patch entirely, but in case we don't drop it: i think the simplest approach to serve the purpuse is to make one list containing all the "concrete" classes implemented in this file. like ALL_CONFIGURABLE_PARAMETERS = [Imsi, Iccid, ....] the fixed list because: it's questionable whether magically using all implemented subclasses is a good idea for anyone. I mean, *any* merged patch or imported module that happens to contain *any* weird experimental kind of ConfigurableParameter subclass suddenly appears in a magic discovery list. It's like a global variable. Do I want that to mess with my eSIM profiles in unexpected ways? No, so the list should be static, not magic. i.e. anything using inheritance discovery is IMO not a good idea and it should be static. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4970657294130b6b65d50ff19ffbb9ebab3be609 Gerrit-Change-Number: 40095 Gerrit-PatchSet: 6 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Sun, 11 Jan 2026 04:02:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
