neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40095?usp=email )
Change subject: personalization: discover all useful ConfigurableParameter subclasses ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: I've rethought the concept of this patch. The purpose of the is_abstract flag is to magically create a list of all parameters that I want. The real functionality now is, it provides always the same specific list of all parameters, stable or experimental. Instead, I think we could just drop this patch completely. Or, if we keep this, then add a specific tuple of parameter classes in the end of the module. (or a function returning a list? doesn't really matter) For downstream projects, it matters that they can control which parameters suddenly appear in their user interfaces. They want to maybe stay with the bunch of *stable* parameters, so a list of stable paramters and a list of experimental parameters? In favor of simplicity, I think I would just drop this patch and put the burdon of selecting classes completely onto the caller. i.e. instead of adding one specific list here for who knows what purposes, let the callers make their own list because they do know their purpose. And they should anyway explicitly control what parameters they expose. We don't really need the magic discovery and it is actually harmful. agreed? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4970657294130b6b65d50ff19ffbb9ebab3be609 Gerrit-Change-Number: 40095 Gerrit-PatchSet: 6 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Sun, 11 Jan 2026 03:52:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
