Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email )
Change subject: RTP: implement RTP socket abstraction layer ...................................................................... Patch Set 3: (6 comments) File include/osmo-bts/rtp_abstract.h: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/39fe3690_b5f15344?usp=email : PS3, Line 50: struct sockaddr_in local_addr; struct osmo_sockaddr, so we support IPv6 too. File src/common/rtp_abstract.c: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/3efa75ea_0e081e13?usp=email : PS3, Line 14: #define HAVE_ORTP s/tab/space/ ? https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/dd1998c4_27878f6b?usp=email : PS3, Line 54: #ifdef HAVE_ORTP I think splitting the whole implementation into 2 different main blocks (reimplementing functions on each one) will be a lot cleaner and easy to understand and maintain, as well as easier to drop ortp in the future. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/e3e7de7e_9727f8a5?usp=email : PS3, Line 97: rc = inet_aton(ipstr, &rs->local_addr.sin_addr); osmo_sockaddr_from_str_and_uint(), so we support ipv6 too. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/18e3f01d_ecdc000d?usp=email : PS3, Line 109: const struct in_addr *ip, uint16_t port) Ah I see, we didn't support IPv6 here yet because ortp doesn't support it? Then it's fine to skip IPv6 support for now, but still it may be good to pave the way by using osmo_sockaddr functions to it's easier to enable in the future. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/98119c15_f6c169d7?usp=email : PS3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true); is it needed to call this every time we poll? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f Gerrit-Change-Number: 42165 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: falconia <[email protected]> Gerrit-Comment-Date: Mon, 23 Feb 2026 08:45:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
