Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email )
Change subject: RTP: implement RTP socket abstraction layer ...................................................................... Patch Set 4: Code-Review+2 (4 comments) File include/osmo-bts/rtp_abstract.h: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/57c8f44c_c2f881f9?usp=email : PS3, Line 50: struct sockaddr_in local_addr; > Please see my comment in the main IPv6 thread. Done File src/common/rtp_abstract.c: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/07a7fde6_cb2d5c09?usp=email : PS3, Line 54: #ifdef HAVE_ORTP > How do you propose doing so? Each function needs to check if the > `rtp_abst_socket` it operates on wa […] Indeed when I was reviewing and writing the comment I thought you planned to enable one or the other at build time. It's fine then. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/1ae8d477_aa2f145e?usp=email : PS3, Line 97: rc = inet_aton(ipstr, &rs->local_addr.sin_addr); > Please see my comment in the main IPv6 thread. Done https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/a49d0339_5c347358?usp=email : PS3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true); > I added an extra comment in the code explaining this aspect. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f Gerrit-Change-Number: 42165 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: falconia <[email protected]> Gerrit-Comment-Date: Tue, 24 Feb 2026 09:45:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
