Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email )
Change subject: RTP: implement RTP socket abstraction layer ...................................................................... Patch Set 3: (3 comments) File src/common/rtp_abstract.c: https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/83a67ca3_8c3347b5?usp=email : PS3, Line 14: #define HAVE_ORTP > s/tab/space/ ? I will change it in the next iteration if Osmocom style preference is to use space here. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/51e6e1f8_937a0c61?usp=email : PS3, Line 54: #ifdef HAVE_ORTP > I think splitting the whole implementation into 2 different main blocks > (reimplementing functions on […] How do you propose doing so? Each function needs to check if the `rtp_abst_socket` it operates on was created in ortp or twrtp mode. https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/c538eb24_f08a3a2b?usp=email : PS3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true); > is it needed to call this every time we poll? Not needed, but no harm either. We do need to make sure that it is only called when we are truly ready to commit to polling, and I couldn't find a better way. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic945f6d753ec7f5c0ac5cecc9f71049464de7e8f Gerrit-Change-Number: 42165 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 23 Feb 2026 09:05:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
