Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, 
pespin.

laforge has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email )

Change subject: Use talloc to allocate asn1c decoded structs
......................................................................


Patch Set 2:

(1 comment)

File src/tcap.c:

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/413b32cd_87d289c0?usp=email
 :
PS2, Line 29: vo
> We could mark it as a week symbol to avoid breakage "void 
> *tcap_talloc_asn1_ctx __attribute__((weak) […]
Breaking applications forgetting to do so is the point 😊 I actually would 
consider it very positive as this forces the authors of those programs to think 
about where and how to track the talloc usage.  Realistically, it's only 
osmo-stp anyway...



--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9
Gerrit-Change-Number: 42219
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Fri, 27 Feb 2026 10:53:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to