Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 2: (1 comment) File src/tcap.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/2d28135a_20975b04?usp=email : PS2, Line 29: vo > > I would have expected libosmo-sigtran to take care of integrating the […] I'm aware. but in a way that means any other future program using the library without explicitly calling your new API function will again run into the problem of not having the tcap talloc context hooked up anywahere. That's my entire point here: the external symbol of libasn1c makes sure nobody falls into that trap again when they start using the librarry. They must provide a talloc context and hence think about it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Fri, 27 Feb 2026 11:51:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
