Attention is currently required from: daniel, fixeria, lynxis lazus, osmith, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 2: (1 comment) File src/tcap.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/b39aa7cf_cad0f06e?usp=email : PS2, Line 29: vo > So are you proposing then having the external symbol tcap_talloc_asn1_ctx (or > whatever name) defined in libosmo-sigtran then? yes, ideallt with an osmo prefix. > What happens then if a program linking to libosmo-sigtran also wants to use > libosmo-asn1-tcap directly? defining the external symbol tcap_talloc_asn1_ctx > again would probably fail? Valid point. Seems like we have not yet encountered that with libasn1c, which uses that method. Seems like osmo-hnbgw, osmo-hnodeb, osmo-iuh, osmo-msc, osmo-remsim-{client,bankd,server} and osmo-sgsn seem to be the current users. I guess if they are all defined as weak, it should work? Haven't tested it yet, though. I'm not saying you must go that way, just saying "we've done it this way for that reason in libasn1c". -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Fri, 27 Feb 2026 12:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
