Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11562 )
Change subject: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Emulation.ttcn File library/RSL_Emulation.ttcn: https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Emulation.ttcn@192 PS2, Line 192: private function f_cid_by_ra_fn2(OCT1 ra, RSL_IE_FrameNumber fn) > Why are you using RSL_IE_FrameNumber here, but f_cid_by_ra_fn is using > GsmFrameNumber? […] Regarding fn parameter: I'm using RSL_IE_FrameNumber because that's what I was getting during receive of tr_RSL_CHAN_RQD. Other way would have been to transform what I received in tr_RSL_CHAN_RQD into a GsmFrameNumber, but the function doing the opposite cnversion was already available for a similar structure [function f_compute_ReqRef(uint8_t ra, GsmFrameNumber fn) return RequestReference] so it was easir to follow this path. Regarding replacement: It's not a replacement, as the logic to find/match it's not exactly the same as in f_cid_by_ra_fn, since this one is more relaxed. Of course f_cid_by_ra_fn2 could also be used in other places were f_cid_by_ra_fn is used, but in other places f_cid_by_ra_fn is better because we can match for fn in all cases there (BSC tests). https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Emulation.ttcn@194 PS2, Line 194: var RSL_IE_FrameNumber ct_fn; > unused variable I'll remove it, thanks, that's a leftover from an older version of the patch. https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Emulation.ttcn@427 PS2, Line 427: var GsmFrameNumber fn; > Unused? I'll remove, leftover from old version of patch. I think both ra and fn can be removed. https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Types.ttcn File library/RSL_Types.ttcn: https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Types.ttcn@462 PS2, Line 462: template (value) RSL_IE_FrameNumber ts_RSL_IE_FrameNumber(GsmFrameNumber fn) := { > ...right here. […] Nice thanks for pointing out. A I said I was inspired by: function tr_compute_ReqRef(template uint8_t ra, template GsmFrameNumber fn) -- To view, visit https://gerrit.osmocom.org/11562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I438fd3ee82d88498d928dbcc89ce9bd80d37ab64 Gerrit-Change-Number: 11562 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Fri, 02 Nov 2018 07:58:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No