Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11562 )
Change subject: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11562/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11562/3//COMMIT_MSG@11 PS3, Line 11: and since notification to RSL Emulation happens async, it : can happen (verified) that ChanRqd message from BTS arrives and is : handled before we register the RACH req into the ConnectionTable > one option that could be investigated is to temporarily pause processing of > any RSL events until you […] I think current implementation is fine, since anyway we check for correct FN during RSL.receive() match in f_rach_req_wait_chan_rqd -- To view, visit https://gerrit.osmocom.org/11562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I438fd3ee82d88498d928dbcc89ce9bd80d37ab64 Gerrit-Change-Number: 11562 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Mon, 05 Nov 2018 10:32:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No