Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11562 )
Change subject: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11562/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11562/3//COMMIT_MSG@11 PS3, Line 11: and since notification to RSL Emulation happens async, it : can happen (verified) that ChanRqd message from BTS arrives and is : handled before we register the RACH req into the ConnectionTable one option that could be investigated is to temporarily pause processing of any RSL events until you have received the fn from L1CTL and installed the expectation in the ConnectionTable. We already have this kind of logic as 'dchan_suspended' in RSL_Emulation.ttcn. You could also have something like a chan_rqd_suspended and set/unset that via procedure port. I'm not saying it must be done that way, I'm just stating this is a proven option to work around such races. -- To view, visit https://gerrit.osmocom.org/11562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I438fd3ee82d88498d928dbcc89ce9bd80d37ab64 Gerrit-Change-Number: 11562 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Fri, 02 Nov 2018 22:16:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
