Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface ...................................................................... Patch Set 29: (4 comments) https://gerrit.osmocom.org/#/c/11642/29/include/osmocom/msc/ran_conn.h File include/osmocom/msc/ran_conn.h: https://gerrit.osmocom.org/#/c/11642/29/include/osmocom/msc/ran_conn.h@216 PS29, Line 216: RAN_CONN_USE_SGs_SERVICE Missing comma. https://gerrit.osmocom.org/#/c/11642/29/include/osmocom/msc/vlr.h File include/osmocom/msc/vlr.h: https://gerrit.osmocom.org/#/c/11642/29/include/osmocom/msc/vlr.h@114 PS29, Line 114: struct vlr_subscr; Why do we need this? I don't see any references to this struct. https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/gsm_04_08.c@455 PS29, Line 455: ws https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/gsm_subscriber.c File src/libmsc/gsm_subscriber.c: https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/gsm_subscriber.c@119 PS29, Line 119: Note I think this note should precede the function definition. -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d Gerrit-Change-Number: 11642 Gerrit-PatchSet: 29 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Tue, 08 Jan 2019 13:17:02 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
