Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface ...................................................................... Patch Set 29: feedback on some of my initial concerns, which we talked about in person: TLDR: all of my higher level concerns are addressed and we're good to go. - paging: the SGs indeed registers the subscriber with the 2G MSC, after which it stays valid in the VLR without a timeout, i.e. without periodic LU being required. - HLR: the SGs indeed contacts the HLR correctly. After it has registered a subscriber in the VLR including a GSUP LU procedure, it stays in the VLR until an IMSI Detach or until the SGs interface goes down, so a vlr_susbcr_find_*() is indeed sufficient. - inter-MSC HO: the SGs interface state is already placed in the vlr_subscr struct, hence there will be no need to separate it from the ran_conn in order to keep the SGs at the MSC-A. -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d Gerrit-Change-Number: 11642 Gerrit-PatchSet: 29 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Fri, 11 Jan 2019 19:26:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
