On Tue, 2016-09-06 at 16:47 +0200, Carmelo DrRaw wrote: > > > > On 06 Sep 2016, at 16:41, Michael Natterer <mi...@gimp.org> wrote: > > > > On Tue, 2016-09-06 at 16:30 +0200, Carmelo DrRaw wrote: > > > > In GIMP git master, you would say > > > > gimp_preview_area_set_color_config (gimp_preview_get_area > > (preview), > > gimp_get_color_configuration > > ()); > > > > Thanks! However, I assume that the ICC conversion is done in this > case using 8-bits precision, right? > > I would like to take advantage of the fact that G’MIC handles > floating-point precision, by doing the ICC conversion before the > conversion to 8-bits…
Moreover, this API only makes sure an assumed-to-be-sRGB image is displayed correctly in 8 bit. You can omit this call, and feed color-corrected pixels to the preview directly, look at the GimpColorTransform API in libgimpcolor, which is a simple wrapper around lcms (which you don't need to use at all). For the image profile, use gimp_image_get_effective_color_profile(), for getting the transform, best use gimp_widget_get_color_transform() which will look up the right display profile by itself. Also, use gimp_widget_track_monitor() so you can recreate the transform when the window is moved to another monitor. For example code, grep for gimp_widget_get_color_transform gimp_widget_track_monitor in libgimpwidgets/ and app/widgets/ Regards, --Mitch > > > > > > > My question was if this is a plug-in against GIMP 2.8 (soon > > obsolete) > > or against GIMP git master. > > > > I wouldn't bother do add color management to a GIMP 2.8 plug-in > > and I have never tried. > > I see… G’MIC is already adapted to high bit depth and 2.9 API, so I > think it is worth adding proper color management. > > Regards, > Andrea > > _______________________________________________ > gimp-developer-list mailing list > List address: gimp-developer-list@gnome.org > List membership: https://mail.gnome.org/mailman/listinfo/gimp-develop > er-list > List archives: https://mail.gnome.org/archives/gimp-developer-list _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
