Jeff King <p...@peff.net> writes:
> On Fri, Apr 21, 2017 at 07:27:20PM +0700, Duy Nguyen wrote:
>
>> On Fri, Apr 21, 2017 at 6:52 PM, Junio C Hamano <gits...@pobox.com> wrote:
>> > Yes, but (1) we'd need to be careful about --quiet
>>
>> Yeah. It's a real pain point for making changes like this. At some
>> point we should just have a global (maybe multi-level) quiet flag.
>
> I don't think it's too bad here. Isn't it just:
>
> FILE *fh = quiet ? fopen(x, y) : fopen_or_warn(x, y);
>
> It is a little annoying to have to repeat "x", though (which is
> sometimes a git_path() invocation).
Sure, but you could do
fopen_or_warn(quiet, x, y)
if it is a problem ;-)
