Hi Brian, On 2015-04-24 01:14, brian m. carlson wrote: > On Thu, Apr 23, 2015 at 11:53:04AM -0400, Jeff King wrote: > >> If I were writing from scratch, I would probably keep things as tight as >> possible, like: >> >> const char *base = basename(ssh); >> plink = !strcasecmp(base, "plink") || >> !strcasecmp(base, "plink.exe"); >> tplink = !strcasecmp(base, "tortoiseplink") || >> !strcasecmp(base, "tortoiseplink.exe")); >> >> but maybe that is too tight at this point in time; we don't really know >> what's out there and working (or maybe _we_ do, but _I_ do not :) ). >> >> At any rate, brian's patch only looks for a dir-separator anywhere, not >> the actual basename. So: >> >> /path/to/plink/ssh >> >> would match, and I'm not sure if that's a good thing or not. > > This is true. In hindsight, I think it's probably better to be a bit > stricter, so I'll reroll to use the stricter format.
Thank you so much! Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
