michaelpearce-gain commented on a change in pull request #2802: ARTEMIS-2457
implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#discussion_r317416619
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -1556,7 +1614,7 @@ public void acknowledge(final MessageReference ref,
final ServerConsumer consume
@Override
public void acknowledge(final MessageReference ref, final AckReason reason,
final ServerConsumer consumer) throws Exception {
- if (nonDestructive && reason == AckReason.NORMAL) {
+ if (isNonDestructive() && reason == AckReason.NORMAL) {
Review comment:
i realise it maybe in-lined but no guarantee.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
