michaelpearce-gain commented on a change in pull request #2802: ARTEMIS-2457
implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#discussion_r317416658
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -179,17 +179,17 @@
private final MpscUnboundedArrayQueue<MessageReference>
intermediateMessageReferences = new MpscUnboundedArrayQueue<>(8192);
// This is where messages are stored
- private final PriorityLinkedList<MessageReference> messageReferences = new
PriorityLinkedListImpl<>(QueueImpl.NUM_PRIORITIES,
MessageReferenceImpl.getIDComparator());
+ protected final PriorityLinkedList<MessageReference> messageReferences =
new PriorityLinkedListImpl<>(QueueImpl.NUM_PRIORITIES,
MessageReferenceImpl.getIDComparator());
// The quantity of pagedReferences on messageReferences priority list
private final AtomicInteger pagedReferences = new AtomicInteger(0);
// The estimate of memory being consumed by this queue. Used to calculate
instances of messages to depage
private final AtomicInteger queueMemorySize = new AtomicInteger(0);
- private final QueuePendingMessageMetrics pendingMetrics = new
QueuePendingMessageMetrics(this);
+ protected final QueueMessageMetrics pendingMetrics = new
QueueMessageMetrics(this, "pending");
Review comment:
again is this needed, making it protected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
