michaelpearce-gain commented on a change in pull request #2802: ARTEMIS-2457
implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#discussion_r317416806
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -881,13 +919,17 @@ public void addHead(final MessageReference ref, boolean
scheduling) {
enterCritical(CRITICAL_PATH_ADD_HEAD);
synchronized (this) {
try {
- if (!scheduling && scheduledDeliveryHandler.checkAndSchedule(ref,
false)) {
- return;
- }
+ enforceRing(ref, scheduling);
Review comment:
can a if check be wrapped around this, to avoid the method (which method is
large and unlikly to be inlined) call when ringsize is disabled (-1)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
