fvaleri commented on a change in pull request #2954: ARTEMIS-2608 Fix
ClassCastException on binary properties retrieval
URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r371889509
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
##########
@@ -610,7 +613,7 @@ private static ActiveMQMessage
toAMQMessage(MessageReference reference,
amqMsg.setCorrelationId(corrId.toString());
}
- final byte[] dsBytes = (byte[])
coreMessage.getObjectProperty(AMQ_MSG_DATASTRUCTURE);
+ final byte[] dsBytes = getBytesPropertyOrNull(coreMessage,
AMQ_MSG_DATASTRUCTURE);
Review comment:
I thought about this, but this actually came out from a legitimate use case
as described in the Jira:
1. Send a message to the broker using OpenWire client
2. Consume that message using AMQP client
3. Send that message back to the broker using AMQP client
Considering the previous use case, at which level you would log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
