fvaleri commented on issue #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval URL: https://github.com/apache/activemq-artemis/pull/2954#issuecomment-600503248 @michaelandrepearce the problem is within the AMQP client. If you create a simple AMQP message resender, then you will see some invalid properties added to the original message (see ARTEMIS-2608 for the reproducer). ``` 3 = {java.util.HashMap$Node@2093} "__HDR_MESSAGE_ID" -> "\x00\x00\x00Ln\x00\x01{\x01\x00%ID:mint.local-50285-1574947728615-1:1\x00\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x00\x00" key = "__HDR_MESSAGE_ID" value = {org.apache.qpid.proton.amqp.Binary@2101} "\x00\x00\x00Ln\x00\x01{\x01\x00%ID:mint.local-50285-1574947728615-1:1\x00\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x00\x00" 4 = {java.util.HashMap$Node@2094} "__HDR_PRODUCER_ID" -> "\x00\x00\x009{\x01\x00%ID:mint.local-50285-1574947728615-1:1\x00\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x00\x01" key = "__HDR_PRODUCER_ID" value = {org.apache.qpid.proton.amqp.Binary@2103} "\x00\x00\x009{\x01\x00%ID:mint.local-50285-1574947728615-1:1\x00\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x00\x00\x00\x00\x01" ``` The OpenWire consumer expects binary data for those keys and the aim of this fix is to make it more robust, while also solving a real use case problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
