michaelandrepearce commented on a change in pull request #2954: ARTEMIS-2608
Fix ClassCastException on binary properties retrieval
URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r389312212
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
##########
@@ -963,4 +966,13 @@ private static void setAMQMsgObjectProperties(final
ActiveMQMessage amqMsg,
}
}
}
+
+ private static byte[] getBytesPropertyOrNull(ICoreMessage coreMessage,
SimpleString property) {
+ try {
+ return coreMessage.getBytesProperty(property);
Review comment:
this shouldn't be catching property conversion exception, instead it should
check if coremessage has property and return null, should still be allowing
ActiveMQPropertyConversionException to propagate up if there's an actual
conversion issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
